Skip to content

Conversation

@camposandro
Copy link
Collaborator

Rename missing read_hats calls in the documentation pages and tutorials. Closes #854.

@camposandro camposandro requested a review from dougbrn July 11, 2025 14:46
@camposandro camposandro self-assigned this Jul 11, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Before [5027fd6] After [221517e] Ratio Benchmark (Parameter)
37.9±0.5ms 38.1±0.8ms 1.01 benchmarks.time_polygon_search
6.18±0.05s 6.18±0.02s 1 benchmarks.time_create_large_catalog
80.5±1ms 80.3±1ms 1 benchmarks.time_kdtree_crossmatch
916±6ms 910±2ms 0.99 benchmarks.time_create_midsize_catalog
24.7±0.5ms 24.3±0.2ms 0.98 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (5027fd6) to head (0ae606c).
⚠️ Report is 147 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          54       54           
  Lines        2570     2570           
=======================================
  Hits         2447     2447           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@camposandro camposandro merged commit f2b473e into main Jul 11, 2025
13 checks passed
@camposandro camposandro deleted the issue/854/open_catalog branch July 11, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

open_catalog docstring uses read_hats instead of open_catalog in the examples+discussion

3 participants