Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Closes #938

Additional changes in this PR address pre-existing linting issues.

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

Before [d87f4b9] After [fed3e03] Ratio Benchmark (Parameter)
42.6±3ms 38.2±0.6ms ~0.90 benchmarks.time_polygon_search
6.40±0.04s 6.38±0.03s 1.00 benchmarks.time_create_large_catalog
24.1±0.5ms 23.7±0.3ms 0.98 benchmarks.time_box_filter_on_partition
963±20ms 944±7ms 0.98 benchmarks.time_create_midsize_catalog
85.3±4ms 78.9±1ms 0.92 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (d87f4b9) to head (29adf1d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #988   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          54       54           
  Lines        2553     2554    +1     
=======================================
+ Hits         2473     2474    +1     
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucchi-cmu delucchi-cmu merged commit e7dd698 into main Aug 12, 2025
12 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/938/cone_astropy branch August 12, 2025 17:12
@delucchi-cmu delucchi-cmu mentioned this pull request Aug 14, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite cone_filter to not use astropy

3 participants