Tutorial for Scheduling #218
Conversation
|
@kvyh You'll have to rebase this branch. |
|
The conflict was in a part of the code that I no longer needed, so I removed it. |
|
It looks like the commit fixed the issue that was occurring with numpy1.7 (I don't really understand why), but the checks for this branch are running very slowly. Is there any way to help with the speed? |
| @@ -21,70 +22,182 @@ | |||
| dec=89.26410897 * u.deg), name="Polaris") | |||
|
|
|||
| apo = Observer.at_site('apo') | |||
| targets = [vega, rigel, polaris] | |||
| targets = [vega, polaris, rigel] | |||
| default_time = Time('2016-02-06 03:00:00') | |||
There was a problem hiding this comment.
Could you call this "tricky_time" or something that indicates that this is a time where float evaluations go bad, which you're testing specifically?
There was a problem hiding this comment.
That default time is used in all of the tests, not just the insert_slot, would it be better to create the Time object separately for each test?
There was a problem hiding this comment.
It's probably better to move the time into each test, because ideally in the future that will be updated to test multiple times (having only one test time is a pretty narrow test).
|
Does this replace #203? |
| @@ -683,7 +683,7 @@ def _make_schedule(self, blocks): | |||
| end_idx = times_indices + start_idx | |||
| # this may make some OBs get sub-optimal scheduling, but it closes gaps | |||
| # TODO: determine a reasonable range inside which it gets shifted | |||
| if (tb.duration > new_start_time - tb.start_time or | |||
| if (new_start_time - tb.start_time < tb.duration or | |||
kvyh
force-pushed
the
tutorial_for_scheduling
branch
from
4afe41f
to
9c09447
Compare
|
Hey @bsipocz – some doctests are failing when we try to import matplotlib in the docs now. Could that be a result of any of the recent CI changes? Just want to check with you before I do some real digging. |
|
@bmorris3 - According to the docs, mpl is optional dependency only, so no wonder the tests fail when it is not available. |
|
That can easily be fixed by just skipping the doctests for it, like the plotting tutorial does. |
|
There is On 12 August 2016 at 20:01, Brett M. Morris notifications@github.com
|
|
Reminder to rebase this branch after the changes in #219 were merged. |
kvyh
force-pushed
the
tutorial_for_scheduling
branch
from
c8611a4
to
ad74d55
Compare
|
I rebased this and changed the tests to use the new |
kvyh
force-pushed
the
tutorial_for_scheduling
branch
from
ad74d55
to
f852f99
Compare
|
I'm currently trying to build the sphinx docs from your tutorial, and they're taking forever. Either there's a problem with the code in there, or the code is way too slow. |
…r and scheduler errors
rewrote defining targets changed the tutorial to observation of M13 and Deneb removed conflict
kvyh
force-pushed
the
tutorial_for_scheduling
branch
from
2ce93bf
to
e693ec5
Compare
|
I have added the suggestions and rebased on the newest changes, it is much faster to build now. |
|
Thanks @kvyh! This is a big one. |
This contains the Scheduling Tutorial in the docs, but was rebased off of code that it requires to function. This will replace #208 and is intended to solve #200 .
There is a work left to do on the tutorial itself so that it better reflects how it would be used, so I will be rewriting specific parts of it over the coming days.