New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date #341

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
3 participants
@bmwiedemann
Contributor

bmwiedemann commented Sep 26, 2017

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Without this patch, the python-sunpy openSUSE package differed
for every build

@astropy-bot

This comment has been minimized.

Show comment
Hide comment
@astropy-bot

astropy-bot bot Sep 26, 2017

Hi there @bmwiedemann 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here

astropy-bot bot commented Sep 26, 2017

Hi there @bmwiedemann 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here

@astrofrog

This comment has been minimized.

Show comment
Hide comment
@astrofrog

astrofrog Sep 26, 2017

Member

Thanks! I think this is a nicer solution to the problem than #146

Member

astrofrog commented Sep 26, 2017

Thanks! I think this is a nicer solution to the problem than #146

@bsipocz

This comment has been minimized.

Show comment
Hide comment
@bsipocz

bsipocz Sep 26, 2017

Member

I could probably use a brief changelog entry. Could you @bmwiedemann add one for 2.0.2?

Member

bsipocz commented Sep 26, 2017

I could probably use a brief changelog entry. Could you @bmwiedemann add one for 2.0.2?

Allow to override build date
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Without this patch, the python-sunpy openSUSE package differed
for every build
@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 29, 2017

Contributor

Changelog entry was added

Contributor

bmwiedemann commented Sep 29, 2017

Changelog entry was added

@bsipocz bsipocz merged commit 231766d into astropy:master Sep 29, 2017

4 checks passed

astropy-bot All checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 68.764%
Details
@bsipocz

This comment has been minimized.

Show comment
Hide comment
@bsipocz
Member

bsipocz commented Sep 29, 2017

Thanks @bmwiedemann!

bsipocz added a commit that referenced this pull request Oct 10, 2017

Merge pull request #341 from bmwiedemann/date
Allow to override build date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment