New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v4.1+ deprecated code from modeling #11978
Remove v4.1+ deprecated code from modeling #11978
Conversation
Hello @WilliamJamieson 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style. There are no PEP8 style issues with this pull request - thanks! 🎉 Comment last updated at 2021-07-29 19:42:58 UTC |
Tagging @nden and @perrygreenfield. |
p.s. There were also discussions on max line length (5 lines?) for the change log fragment. |
da4b221
to
db031a7
Compare
It is difficult to read if I reduce the text to fewer lines in my opinion. However, I can do so if this is what is desired now. |
Re: change log length -- you can ignore me. 5 line isn't hard limit. 😅 |
Removed deprecated models `MexicanHat1D` and `MexicanHat2D`. Removed deprecated code in `~astropy/modeling/core.py`. Removed deprecation filtering from tests. Fixed codestyle error. Added changelog entry. Updated changelog entry.
ed99fdd
to
d65d668
Compare
Description
The following has been marked as deprecated (with removal starting in v4.1) in modeling:
ExpressionTree
MexicanHat1D
andMexicanHat2D
inputs
inModel
CompoundModel
inverse
parameterCompoundModel.both_inverses_exist()
methodThis PR removes all of these things for future astropy versions.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CI
label.no-changelog-entry-needed
label.astropy-bot
check might be missing; do not let the green checkmark fool you.backport-X.Y.x
label(s) before merge.