Fix a bug in NDData constructor where WCS was not validated correctly #11985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
added
💤 backport-v4.3.x
Cadair
force-pushed
the
nddata_wcs_init
branch
2 times, most recently
from
536683f
to
6c2f2ea
Compare
|
100 failures... |
|
Ah, looks like the failures may be related to #11727. Essentially the issue is that the WCS cannot currently be |
Cadair
force-pushed
the
nddata_wcs_init
branch
from
6c2f2ea
to
effb97f
Compare
|
I have fixed the test fails by allowing ccddata to accept None when passed to the setter. |
|
@mwcraig Can we merge this? |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Oct 20, 2021
…was not validated correctly
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Oct 20, 2021
…was not validated correctly
|
@Cadair I think you have broken the sunpy tests with this: https://app.circleci.com/pipelines/github/sunpy/sunpy/14750/workflows/ef2a05ba-d904-4c63-96ff-c262e937afd4/jobs/71735 - not sure whether there's something we need to change in sunpy or astropy? |
|
I suspect that's a sunpy bug (we override the property but not the setter). |
pllim
added a commit
that referenced
this pull request
Oct 26, 2021
…985-on-v4.3.x Backport PR #11985 on branch v4.3.x (Fix a bug in NDData constructor where WCS was not validated correctly)
Cadair
added a commit
that referenced
this pull request
Oct 29, 2021
…985-on-v4.0.x Backport PR #11985 on branch v4.0.x (Fix a bug in NDData constructor where WCS was not validated correctly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not running the input WCS through the property setter which means it wasn't getting up-converted to a High Level WCS object which then would later break when that assumption was relied upon.