Remove deprecated arguments from astropy.stats

[eerovaher]

Description

The bls and lombscargle modules were deprecated in #8591.
The keyword arguments removed in this pull request were deprecated in #9408.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
• Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
• Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

[larrybradley]

LGTM, thanks!

[bsipocz]

I'm worried that there is still a lot of code outside that imports these from astropy.stats, and I would argue the need for longer deprecation.

[bsipocz]

I would keep LS and BLS for one more LTS cycle, the rest looks good.

[bsipocz]

This way of populating the namespace is actually quite nice, so I would keep it anyway as opposed to rely on * imports.

[eerovaher]

If we are not removing the deprecated modules then this file can't be changed either.

[eerovaher]

The bls and lombscargle modules were deprecated in astropy 3.2, so they have already been kept for more than one full LTS cycle.

[bsipocz]

@eerovaher - my point stands, based on the experience of teaching and working with many people using these functions. There are still many importing these from astroML, and also from gatspy. So if you aim to stay user friendly, then it's being kept for longer. After all, e.g. clobber hasn't been removed at the first possible occasion either.

[larrybradley]

Given the comments from @bsipocz , can you please update this PR to include only the deprecated renamed arguments?

[nstarman]

It looks like all changes requested by @bsipocz and @larrybradley are complete.
LGTM! Thanks @eerovaher.

[larrybradley]

Thanks, @eerovaher.