Add kwargs to to_mapping
#12710
Merged
Add kwargs to to_mapping
#12710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thank you for your draft pull request! Do you know that you can use |
Add ``cosmology_as_str`` and ``move_from_meta`` to customize how the cosmology class and metadata are returned, respectively. Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
nstarman
force-pushed
the
cosmo-add-arguments-to-to_mapping
branch
from
91a38b9
to
2f06ec0
Compare
mhvk
approved these changes
Jan 10, 2022
astropy/cosmology/io/mapping.py
Outdated
| >>> from astropy.cosmology import Planck18 | ||
| >>> Planck18.to_format('mapping', move_from_meta=True) | ||
| {'cosmology': <class 'astropy.cosmology.flrw.FlatLambdaCDM'>, | ||
| 'name': 'Planck18', 'Oc0': 0.2607, 'n': 0.9665, 'sigma8': 0.8102, ... | ||
| """ | ||
| if not issubclass(cls, (dict, Mapping)): | ||
| raise TypeError(f"'cls' must be a (sub)class of dict or Mapping, not {type(cls)}") |
There was a problem hiding this comment.
Here, since cls is a class, type is misplaced, right?
There was a problem hiding this comment.
Yes. thanks! I'll fix it here.
Cosmology, the Expansion
automation
moved this from In progress (PR)
to Reviewer approved
Jan 10, 2022
Co-authored-by: Marten van Kerkwijk <mhvk@astro.utoronto.ca> Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
nstarman
added
the
💤 merge-when-ci-passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cosmology_as_strandmove_from_metato customize how the cosmology class and metadata are returned, respectively.Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.