Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure repr/str of structured subarrays works properly #13404

Merged
merged 1 commit into from Jun 28, 2022

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Jun 27, 2022

Description

See title; this was not tested before.

Fixes #13401

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@mhvk mhvk added Bug utils utils.masked 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.1.x on-merge: backport to v5.1.x labels Jun 27, 2022
@mhvk mhvk added this to the v5.0.5 milestone Jun 27, 2022
@mhvk mhvk requested a review from nstarman June 27, 2022 21:58
Copy link
Member

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple and elegant fix.

@mhvk
Copy link
Contributor Author

mhvk commented Jun 28, 2022

What's up with the towncrier check? I'll give it more time, but it seems just stuck...

@mhvk mhvk added Bug and removed Bug labels Jun 28, 2022
@mhvk
Copy link
Contributor Author

mhvk commented Jun 28, 2022

Ah, right, forgot I should set labels after opening the PR.

@mhvk mhvk merged commit 427498f into astropy:main Jun 28, 2022
@mhvk mhvk deleted the masked-structured-subarray-repr branch June 28, 2022 01:01
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jun 28, 2022
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jun 28, 2022
pllim added a commit that referenced this pull request Jun 28, 2022
…404-on-v5.1.x

Backport PR #13404 on branch v5.1.x (Ensure repr/str of structured subarrays works properly)
pllim added a commit that referenced this pull request Jun 28, 2022
…404-on-v5.0.x

Backport PR #13404 on branch v5.0.x (Ensure repr/str of structured subarrays works properly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug utils.masked utils 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.1.x on-merge: backport to v5.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Masked _array2string doesn't work on some structured arrays
2 participants