Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled the equal_nan keyword argument for np.array_equal() when the arguments are astropy.units.Quantity instances. #14135

Merged
merged 1 commit into from Dec 8, 2022

Conversation

byrdie
Copy link
Contributor

@byrdie byrdie commented Dec 7, 2022

The equal_nan keyword argument was added in Numpy 1.19. This PR just adds it to our overload of np.array_equal.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions github-actions bot added the units label Dec 7, 2022
@pllim pllim added this to the v5.3 milestone Dec 7, 2022
@byrdie byrdie force-pushed the feature/array_equal_nan branch 2 times, most recently from 566e695 to 107b91f Compare December 7, 2022 18:23
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! CI is currently broken due to a tox upgrade, but this all looks good to me, so I'll approve.

…the arguments are `astropy.units.Quantity` instances.
@nstarman nstarman merged commit 126fd5a into astropy:main Dec 8, 2022
@byrdie byrdie deleted the feature/array_equal_nan branch December 8, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants