Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement updated IAU B3 2015 constants if approved #4026

Closed
astrofrog opened this issue Jul 31, 2015 · 7 comments
Closed

Implement updated IAU B3 2015 constants if approved #4026

astrofrog opened this issue Jul 31, 2015 · 7 comments

Comments

@astrofrog
Copy link
Member

One of the IAU resolutions that may be passed next week is the following:

http://astronomy2015.org/sites/default/files/RESOLUTION%20B3%20-%20nominal%20conversion%20constants.pdf

It defines official values for things like solar radii, etc. so we should update to use these once approved.

@souravsingh
Copy link

I would like to work on this issue.How do I start?

@mhvk
Copy link
Contributor

mhvk commented Oct 8, 2015

@souravsingh - the relevant files are astropy/constants/si.py and astropy/units/astrophys.py. Be sure to including in the constant docstring that these are nominal values (hence no uncertainty). I think you may want to add polar radii (to the constants, maybe not the units), though am not sure what name to give...

If you're up to it, I'd also suggest to expand the table in the documentation to include the uncertainty, so it is clear at a glance whether values are measured or nominal. This table is generated in astropy/constants/__init__.py.

@embray embray added this to the v1.2.0 milestone Oct 8, 2015
@embray
Copy link
Member

embray commented Oct 8, 2015

Could this lead to differences in numerical results? We might want to be careful about making such a change, even if it's ultimately for the better.

@souravsingh
Copy link

In astropy/units/astrophys.py I found there are no unit for solar effective temperature Assigned within the file.So how do I go on to assigning the unit for it?

@hvardhanx
Copy link

#4397

@astrofrog astrofrog modified the milestones: v1.3.0, v1.2.0 Jun 3, 2016
@mhvk mhvk modified the milestones: Future, v1.3.0 Nov 29, 2016
@mhvk
Copy link
Contributor

mhvk commented Nov 29, 2016

Changing the milestone to "Future" since this is not going to happen for 1.3.

@bsipocz
Copy link
Member

bsipocz commented Jun 16, 2017

Closing as #6083 added iau2015 constants.

@bsipocz bsipocz closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants