deprecate rotateCD #5240
Merged
deprecate rotateCD #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to merge this tomorrow if there are no other comments. |
|
I am all for it. I think the message is fine as it is. The alternative is to use math to derive the correct formula for a given problem. |
nden
force-pushed
the
deprecate-rotateCD
branch
from
e0c3795
to
3dda0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5175 the
rotateCDmethod is confusing and there's a consensus to deprecate it.There's no evidence that this method is used by anyone. Is
1.3a good time to remove it?Are the changes here sufficient for the deprecation?
#5189 will be closed without merging.