Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sphinx-gallery minversion on Travis when appropriate #6266

Closed
pllim opened this issue Jun 22, 2017 · 3 comments · Fixed by #6544
Closed

Update sphinx-gallery minversion on Travis when appropriate #6266

pllim opened this issue Jun 22, 2017 · 3 comments · Fixed by #6544
Labels
Close? Docs Effort-low Package-novice testing Upstream Fix Required

Comments

@pllim
Copy link
Member

pllim commented Jun 22, 2017 •
edited

As mentioned in bsipocz#3 (comment), once sphinx-gallery/sphinx-gallery#255 is included in a proper release, sphinx-gallery minimum version requirement can be updated to get rid of RemovedInSphinx17Warning for app.status_iterator() in the Sphinx build test on Travis.

Also see #6140.
This was referenced Jun 22, 2017
Merged
Merged
@pllim
Copy link
Member Author

pllim commented Sep 13, 2017

Upstream fix was merged in sphinx-gallery/sphinx-gallery#250 and that was back in June. So, this is no longer an issue, @bsipocz ?

@pllim pllim added the Close? label Sep 13, 2017
@bsipocz
Copy link
Member

bsipocz commented Sep 13, 2017

Oh, good catch.

I've updated the min version to 0.1.11 in c560ecd for the sphinx 1.6.1 compatibility as I didn't remembered that we also need sphinx-gallery/sphinx-gallery#250, and that's landed in 0.1.12. Opening a new PR to close this.

@bsipocz bsipocz mentioned this issue Sep 13, 2017
Merged
@pllim
Copy link
Member Author

pllim commented Sep 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Close? Docs Effort-low Package-novice testing Upstream Fix Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating sphinx-gallery version bsipocz/astropy
2 participants
@pllim @bsipocz