Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated renamed arguments in stats package #8948

Merged
merged 3 commits into from Jul 2, 2019
Merged

Remove deprecated renamed arguments in stats package #8948

merged 3 commits into from Jul 2, 2019

Conversation

larrybradley
Copy link
Member

This PR:

  • Removes deprecated_renamed_argument from biweight.py, which was added in 2.0 release
  • Remove deprecated_renamed_argument from sigma_clipping.py, which was added in 3.1 release

Addresses part of #8888

@larrybradley larrybradley added this to the v4.0 milestone Jul 2, 2019
@pllim pllim mentioned this pull request Jul 2, 2019
Closed
16 tasks
bsipocz
bsipocz approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good an uncontroversial to me.

@bsipocz bsipocz merged commit 85034be into astropy:master Jul 2, 2019
@bsipocz
Copy link
Member

bsipocz commented Jul 2, 2019

Thank you @larrybradley!

@larrybradley larrybradley deleted the stats-deprecations branch July 17, 2019 21:57
saimn added a commit to GeminiDRSoftware/DRAGONS that referenced this pull request Oct 24, 2019
@saimn
Fix use of sigma_clip with Astropy 4.0
ba0ed47 
The iters argument was renamed to maxiters and deprecated in Astropy 3.1
(astropy/astropy#7478), and it has been removed
in the dev version (astropy/astropy#8948).
saimn added a commit to GeminiDRSoftware/DRAGONS that referenced this pull request Oct 24, 2019
@saimn
Fix use of sigma_clip with Astropy 4.0
7612f2f 
The iters argument was renamed to maxiters and deprecated in Astropy 3.1
(astropy/astropy#7478), and it has been removed
in the dev version (astropy/astropy#8948).
saimn added a commit to GeminiDRSoftware/DRAGONS that referenced this pull request Oct 24, 2019
@saimn
Fix use of sigma_clip with Astropy 4.0
df9245b 
The iters argument was renamed to maxiters and deprecated in Astropy 3.1
(astropy/astropy#7478), and it has been removed
in the dev version (astropy/astropy#8948).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees
No one assigned
Labels
Refactoring stats
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larrybradley @bsipocz @pllim