Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Tests failures in coordinates caused by IndexError in IERS with numpy-dev #9240

Closed
pllim opened this issue Sep 16, 2019 · 9 comments
Closed

Comments

@pllim
Copy link
Member

pllim commented Sep 16, 2019

A blame on the LOC pointed to #9226 though the PR itself was green. πŸ€·β€β™€οΈ

@mhvk , any idea?

Example log: https://travis-ci.org/astropy/astropy/jobs/585668145

UPDATE

Looks like numpy-dev job did pass in https://travis-ci.org/astropy/astropy/builds/585637569 ("about 2 hours ago" at the time of writing this with numpy 1.18.0.dev0+07a7eb5) but failed in https://travis-ci.org/astropy/astropy/jobs/585641053 (also "about 2 hours ago" with 1.18.0.dev0+07a7eb5). The PR merged seems unrelated to IERS nor coordinates. And no changes were merged into numpy-dev since 8 hours ago. Then, more tests failed on our end in the next run (https://travis-ci.org/astropy/astropy/jobs/585668145). Did IERS data server change something?

@pllim
Copy link
Member Author

pllim commented Sep 16, 2019

I restarted https://travis-ci.org/astropy/astropy/jobs/585668145 to see if it was transient server problem. I cannot reproduce the failures locally.

@mhvk
Copy link
Contributor

mhvk commented Sep 16, 2019

It repeated so does look like a real bug. Strange that it only turns up in doctests!

@mhvk
Copy link
Contributor

mhvk commented Sep 16, 2019

I also cannot seem to reproduce the failures (tried both latest numpy-dev (1.18.0.dev0+6e75b9a) and the one used by travis (1.18.0.dev0+07a7eb5)...

@pllim
Copy link
Member Author

pllim commented Sep 16, 2019

Hang on... I am going to try clear Travis CI cache and rerun it again... 🀞

@pllim
Copy link
Member Author

pllim commented Sep 16, 2019

Looks like some sort of corrupted cache. It is green now. Sorry for the noise!

@pllim pllim closed this as completed Sep 16, 2019
@mhvk
Copy link
Contributor

mhvk commented Sep 16, 2019

Fortunately, I had started on something else... But while testing that, I found a similar issues, which resulted from the IERS-A table not downloading completely. I think we do need to circumvent that by having a cached version or so...

@pllim
Copy link
Member Author

pllim commented Sep 16, 2019

@mhvk , Travis CI is already doing some caching. But if you are talking about the other IERS issues, then I don't have anything useful to contribute. LoL...

@mhvk
Copy link
Contributor

mhvk commented Sep 16, 2019

Ah, that means it might have been the same problem: for me, it seems the finals2000A file was downloaded only partially and it was quite hard to remove it and retry. Maybe something similar happened for travis. In any case, that would seem part of #9182 - so, for once no need to raise a new issue!

@pllim
Copy link
Member Author

pllim commented Sep 16, 2019

Yes, I do suspect that Travis CI cached a corrupted IERS table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants