python setup.py build_sphinx failure for Python 3.x

[astrofrog]

When running:

python setup.py build_sphinx

in Python 3.3, I get the following error:

$ python setup.py build_sphinx
Freezing version number to astropy/version.py
running build_sphinx
creating docs/_build
creating docs/_build/doctrees
creating docs/_build/html
Traceback (most recent call last):
  File "setup.py", line 128, in <module>
    entry_points=entry_points
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/distutils/dist.py", line 929, in run_commands
    self.run_command(cmd)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/distutils/dist.py", line 948, in run_command
    cmd_obj.run()
  File "/Users/tom/dropbox/Code/development/Astropy/astropy/astropy/setup_helpers.py", line 772, in run
    from urllib import pathname2url
ImportError: cannot import name pathname2url

Presumably, the import just needs to be adjusted for Python 3.x. I'm tagging this as 'easy' and it would be a possible patch for GSoC students.

[jdnc]

Hi I am working on this as a GSoC'13 applicant - Madhura Parikh

[astrofrog]

@jdnc - I saw you submitted this as a traditional patch to the mailing list, but we virtually always use pull requests on GitHub to submit the suggested changes, so could you try and open a pull request for this? See this page: http://docs.astropy.org/en/latest/development/workflow/index.html for setting up git properly, then follow the 'workflow for developers'. Thanks!

[jdnc]

Sure I'll open a pull request for this.

[mdboom]

The pull request is #986 -- @jdnc: note that this creates a handy link from the bug to the new pull request.

[jdnc]

@mdboom Thanks for sharing that tip. I have added a new commit to #986 by using the defined variable PY3