Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue mentioned in #1900 #1903

Merged
merged 2 commits into from Dec 16, 2013
Merged

Fix for issue mentioned in #1900 #1903

merged 2 commits into from Dec 16, 2013

Conversation

@nden
Copy link
Contributor

nden commented Dec 13, 2013

#1900 brought up a bug in how parameters are passed to the model.deriv function in LinearLSQFitter.

nden added 2 commits Dec 13, 2013
@eteq

This comment has been minimized.

Copy link
Member

eteq commented Dec 13, 2013

An odd quirk of github: apparently if you put #1900 in the title, github is not smart enough to auto-link... but now I've referenced it in this comment, so I guess that creates the link on the page for #1900.

Anyway, just so we're clear, @nden, this only fixes the LinearLSQFitter, right? Not the underlying issue that model.deriv(x) doesn't always know about the current model parameters?

@nden

This comment has been minimized.

Copy link
Contributor Author

nden commented Dec 16, 2013

Any objections to merging this?

embray added a commit that referenced this pull request Dec 16, 2013
@embray embray merged commit b6d21fe into astropy:master Dec 16, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
embray added a commit that referenced this pull request Dec 16, 2013
Ugh, a3616a8 should have referenced #1903.
embray added a commit that referenced this pull request Feb 12, 2014
embray added a commit that referenced this pull request Feb 12, 2014
@nden nden deleted the nden:linear-models-deriv branch Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.