Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added plots and fixed minor issues in astropy.units docs #4527

Merged
merged 2 commits into from Feb 19, 2016

Conversation

@mirca
Copy link
Member

mirca commented Jan 25, 2016

Does that look okay? #4487
capture d ecran 2016-01-25 a 10 24 10
capture d ecran 2016-01-25 a 10 24 21

@mirca mirca changed the title fix issue #4487 fixes issue #4487 Jan 25, 2016
@astrofrog

This comment has been minimized.

Copy link
Member

astrofrog commented Jan 25, 2016

@mirca - thanks! I think you can also include :include-source: in the plot directives to avoid having to repeat the example twice (the source from the actual plot example will be shown)

@mirca mirca changed the title fixes issue #4487 added plots and fix minor issues in astropy.units docs Jan 27, 2016
@mirca mirca changed the title added plots and fix minor issues in astropy.units docs add plots and fix minor issues in astropy.units docs Jan 27, 2016
@mirca mirca changed the title add plots and fix minor issues in astropy.units docs added plots and fixed minor issues in astropy.units docs Jan 27, 2016
Quantities are automatically converted to the first unit set on a
particular axis, so in the following, the y-axis remains in ``m`` even
though the second line is given in ``cm``::

This comment has been minimized.

Copy link
@mhvk

mhvk Jan 27, 2016

Contributor

I think the double colon :: is used to indicate that the next block is code. I think it is not necessary given the >>>, but do check that the output documentation looks good.

@mhvk

This comment has been minimized.

Copy link
Contributor

mhvk commented Jan 27, 2016

Looks nice!

@mirca

This comment has been minimized.

Copy link
Member Author

mirca commented Jan 30, 2016

@mhvk Thanks!

@mwcraig

This comment has been minimized.

Copy link
Contributor

mwcraig commented Jan 31, 2016

Restarted broken doc build

@mirca

This comment has been minimized.

Copy link
Member Author

mirca commented Feb 9, 2016

@astrofrog @mhvk any further thoughts on this?

@astrofrog

This comment has been minimized.

Copy link
Member

astrofrog commented Feb 9, 2016

@mirca - looks good, thanks! Can you add a changelog entry to the 1.1.2 section in CHANGES.rst?

@mirca

This comment has been minimized.

Copy link
Member Author

mirca commented Feb 9, 2016

@astrofrog 👍 (:

astrofrog added a commit that referenced this pull request Feb 19, 2016
added plots and fixed minor issues in astropy.units docs
@astrofrog astrofrog merged commit ab80f8d into astropy:master Feb 19, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 76.761%
Details
eteq added a commit that referenced this pull request Feb 24, 2016
added plots and fixed minor issues in astropy.units docs
@mirca mirca deleted the mirca:astropy.units-docs-issue4487 branch Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.