New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cone Search URLs for VizieR services due to external changes #4699

Merged
merged 2 commits into from Mar 17, 2016

Conversation

Projects
None yet
2 participants
@pllim
Member

pllim commented Mar 15, 2016

Updated Cone Search URLs for VizieR services due to external changes. Updated URL unescaper to deal with the new URLs. Fixed a minor bug in XML validator to handle division by zero. Updated Cone Search documentation with correct examples.

Who knew one URL change can result in such a mess.

Updated Cone Search URLs for VizieR services due to external changes.…
… Updated URL unescaper to deal with the new URLs. Fixed a minor bug in XML validator to handle division by zero. Updated Cone Search documentation with correct examples.
@pllim

This comment has been minimized.

Member

pllim commented Mar 16, 2016

Any objection to merge this by 5PM EST on Mar 17? If I don't hear anything, I'll merge it then.

@pllim

This comment has been minimized.

Member

pllim commented Mar 17, 2016

No objections, so merging.

pllim added a commit that referenced this pull request Mar 17, 2016

Merge pull request #4699 from pllim/conesearch-vizier-update
Updated Cone Search URLs for VizieR services due to external changes

@pllim pllim merged commit 95b576e into astropy:master Mar 17, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0%) to 76.719%
Details

@pllim pllim added this to the v1.2.0 milestone Mar 17, 2016

@pllim pllim added the Affects-dev label Mar 17, 2016

@pllim pllim deleted the pllim:conesearch-vizier-update branch Mar 17, 2016

pllim added a commit to pllim/astropy that referenced this pull request Apr 4, 2016

Fixed a failed Cone Search test because that test is now using cached…
… result (side effect of astropy#4699) when it is not supposed to. Not sure why I did not catch this earlier.

@astrofrog astrofrog removed the Affects-dev label May 12, 2016

@astrofrog astrofrog modified the milestones: v1.0.10, v1.2.0 Jun 9, 2016

@astrofrog

This comment has been minimized.

Member

astrofrog commented Jun 9, 2016

I've decided to backport this to v1.0.10 since it fixes issues with the remote tests there too

astrofrog added a commit that referenced this pull request Jun 9, 2016

Merge pull request #4699 from pllim/conesearch-vizier-update
Updated Cone Search URLs for VizieR services due to external changes

astrofrog added a commit that referenced this pull request Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment