Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken and permanently redirected links #6745

Merged
merged 10 commits into from Oct 16, 2017
Merged

Conversation

@astrofrog
Copy link
Member

astrofrog commented Oct 16, 2017

Running make linkcheck revealed a bunch of links that were broken or permanently redirected! (I ignored non-permanent redirects). Some of them are just http -> https but since they are permanent redirects I'd like to fix them to avoid warnings when running linkcheck in future.

@crawfordsm @larrybradley - I could not find what the new URL for this one is:

api/astropy.stats.akaike_info_criterion.rst:72: [broken] http://myweb.uiowa.edu/cavaaugh/ms_lec_2_ho.pdf

Could you let me know what this should be instead?

Ah the joys of linking to academic websites 馃槅

@astrofrog astrofrog added the Docs label Oct 16, 2017
@astropy-bot

This comment has been minimized.

Copy link

astropy-bot bot commented Oct 16, 2017

Hi there @astrofrog 馃憢 - thanks for the pull request! I'm just a friendly 馃 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 馃槂.

Everything looks good from my point of view! 馃憤

If there are any issues with this message, please report them here

@astrofrog astrofrog added the Bug label Oct 16, 2017
[docs only] [skip appveyor]
@astrofrog astrofrog force-pushed the astrofrog:fix-links branch from 2ae4382 to a1c01be Oct 16, 2017
@astrofrog astrofrog requested a review from bsipocz Oct 16, 2017
@larrybradley

This comment has been minimized.

Copy link
Member

larrybradley commented Oct 16, 2017

@astrofrog I was able to find a replacement link (and added a commit).

[docs only] [skip appveyor]
@astrofrog astrofrog force-pushed the astrofrog:fix-links branch from 19e9544 to d775ee6 Oct 16, 2017
@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 16, 2017

@larrybradley - thanks!

@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 16, 2017

I just noticed another link where it's not immediately obvious what it should be:

http://homepage.stat.uiowa.edu/~kcowles/s166_2009/lect11.pdf

(at least for me it says 'Forbidden')

@larrybradley

This comment has been minimized.

Copy link
Member

larrybradley commented Oct 16, 2017

I can't find an update for that link.

BTW, I think you clobbered my earlier commit. :)

Copy link
Member

bsipocz left a comment

I've quickly scanned through, seems uncontroversial enough!

@bsipocz

This comment has been minimized.

Copy link
Member

bsipocz commented Oct 16, 2017

I wonder whether we should add running make linkcheck as well as running spell check as a box to tick before major releases? (I don't mean as part of the release, but shortly after feature freeze?)

@larrybradley

This comment has been minimized.

Copy link
Member

larrybradley commented Oct 16, 2017

For the second stats link, I think we should just add a link to the wikipedia page:
https://en.wikipedia.org/wiki/Jackknife_resampling

@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 16, 2017

@bsipocz - yes I think this would be good to add to the checklist of things before release (certainly not something to add to the CI)

@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 16, 2017

@larrybradley - oops! Didn't mean to do that... Can you add it back? (I don't think I have it locally)

@larrybradley

This comment has been minimized.

Copy link
Member

larrybradley commented Oct 16, 2017

@astrofrog Done. I also replaced the broken jackknife link.

astrofrog added 2 commits Oct 16, 2017
[docs only] [skip appveyor]
[docs only] [skip appveyor]
@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 16, 2017

Since @bsipocz already approved this, I'll go ahead and merge

@astrofrog astrofrog merged commit 135589f into astropy:master Oct 16, 2017
3 checks passed
3 checks passed
astropy-bot All checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bsipocz added a commit that referenced this pull request Jan 14, 2018
Update broken and permanently redirected links
@astrofrog astrofrog deleted the astrofrog:fix-links branch Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.