Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cfitsio to v3.43: includes critical bug fix #7274

Merged
merged 2 commits into from Mar 9, 2018

Conversation

@drdavella
Copy link
Contributor

commented Mar 9, 2018

This fixes #7272. I'll open a separate PR for backporting to 2.0.x.

@drdavella drdavella added this to the v3.0.1 milestone Mar 9, 2018

@astropy-bot

This comment has been minimized.

Copy link

commented Mar 9, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@pllim pllim added the external label Mar 9, 2018

@MSeifert04

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

LGTM provided the tests pass.

Just a question: Why the euv variable in the script?

@drdavella

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2018

@MSeifert04 the script wasn't working for me at first, so I added those flags to help me debug it. I forgot to remove them before committing but it seems like there's no reason to remove them at this point:

http://tldp.org/LDP/abs/html/options.html

@mhvk

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

Happy to see you found my script (and sorry that it didn't work immediately...)

@mhvk

mhvk approved these changes Mar 9, 2018

Copy link
Contributor

left a comment

Yikes, buffer overflows in one of the standard forms... Good to have the update. One comment is really just a question.

@@ -29,7 +31,7 @@ rm -f cfitsio/docs/*.ps
rm -f cfitsio/docs/*.pdf
rm -f cfitsio/docs/*.doc
rm -f cfitsio/docs/*.toc
rm -f cfitsio/[^L]*.*
rm -rf cfitsio/[^L]*.*

This comment has been minimized.

Copy link
@mhvk

mhvk Mar 9, 2018

Contributor

I'm surprised by the need for this change - this means that in the new cfitsio library there is a directory with a . in its name. Out of curiosity, what is it?

This comment has been minimized.

Copy link
@pllim

pllim Mar 9, 2018

Member

I guess I should wait till this is answered before merging?

This comment has been minimized.

Copy link
@drdavella

drdavella Mar 9, 2018

Author Contributor

For me it was cfitsio/cfitsio.xcodeproj, which appears to be generated when building (on OSX for me). Maybe we should just explicitly remove that file rather than using -rf here?

This comment has been minimized.

Copy link
@mhvk

mhvk Mar 9, 2018

Contributor

So, that must be a new directory. I think I'd prefer removing it explicitly, but honestly I don't really know why...

@eteq

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

Alright, all passed and approved, so merging now.

@eteq eteq merged commit 17c785a into astropy:master Mar 9, 2018

6 checks passed

astropy-bot All checks passed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl153 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl202 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl212 Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at ?%
Details

@drdavella drdavella deleted the drdavella:update-cfitsio branch Mar 9, 2018

bsipocz added a commit that referenced this pull request Mar 12, 2018

Merge pull request #7274 from drdavella/update-cfitsio
Update cfitsio to v3.43: includes critical bug fix

@bsipocz bsipocz added Manual Backport and removed Bug labels Mar 12, 2018

@bsipocz bsipocz modified the milestones: v3.0.1, v2.0.5 Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.