Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running test suite with coverage enabled on Windows #7673

Merged
merged 2 commits into from Jul 21, 2018

Conversation

Projects
None yet
3 participants
@ritiek
Copy link
Contributor

ritiek commented Jul 21, 2018

There is a bug where running ./setup.py test with --coverage causes a SyntaxError on Windows. Check out PlasmaPy/PlasmaPy#516 for more info.

This PR fixes it by passing the path as raw strings.

@astropy-bot

This comment has been minimized.

Copy link

astropy-bot bot commented Jul 21, 2018

Hi there @ritiek 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@bsipocz bsipocz merged commit 908fa84 into astropy:master Jul 21, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
astropy-bot All checks passed
Details
@bsipocz

This comment has been minimized.

Copy link
Member

bsipocz commented Jul 21, 2018

Thanks @ritiek!

@bsipocz bsipocz added the Bug label Jul 21, 2018

@pllim pllim added the Windows label Jul 21, 2018

@ritiek ritiek deleted the ritiek:fix-test-coverage branch Jul 21, 2018

bsipocz added a commit that referenced this pull request Jul 25, 2018

Merge pull request #7673 from ritiek/fix-test-coverage
Fix running test suite with coverage enabled on Windows

bsipocz added a commit that referenced this pull request Jul 25, 2018

Merge pull request #7673 from ritiek/fix-test-coverage
Fix running test suite with coverage enabled on Windows

bsipocz added a commit that referenced this pull request Jul 25, 2018

Merge pull request #7673 from ritiek/fix-test-coverage
Fix running test suite with coverage enabled on Windows

bsipocz added a commit that referenced this pull request Aug 2, 2018

Merge pull request #7673 from ritiek/fix-test-coverage
Fix running test suite with coverage enabled on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.