Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistakes in documentation and code #7942

Merged
merged 6 commits into from Oct 23, 2018

Conversation

@astrofrog
Copy link
Member

astrofrog commented Oct 21, 2018

While working on #7761, I've fixed a bunch of spelling mistakes in the docs and code. There may be some left, but this should be a large fraction of them, so we might as well get this reviewed and merged and I can open another PR in future if I find more.

@mhvk: There is one actual code change that may require a closer look - in astropy.units, emittance was misspelt in the physical type. Is that an ok change?

Backporting this may be a pain, but I'll mark it as 2.0.10 for now and we can always bail if the backporting proves too difficult.

And yes, I realize (or realise) the irony of a brit correcting some words to US spelling... But since most of the docs assume this, I thought consistency would be best.

@astrofrog astrofrog added the Docs label Oct 21, 2018
@astrofrog astrofrog added this to the v2.0.10 milestone Oct 21, 2018
@astropy-bot

This comment has been minimized.

Copy link

astropy-bot bot commented Oct 21, 2018

Hi there @astrofrog 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@astrofrog astrofrog force-pushed the astrofrog:fix-spelling branch from 738d103 to 4e26af9 Oct 21, 2018
@astrofrog astrofrog requested review from mhvk and bsipocz Oct 21, 2018
@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 21, 2018

The bot is confused - there are no changelog entries...

Copy link
Member

bsipocz left a comment

they all look good to me, but I shouldn't really be the person to review spelling ;)

@pllim

This comment has been minimized.

Copy link
Member

pllim commented Oct 22, 2018

p.s. I tried added "skip changelog check" label to un-confuse the bot but issue not updating, probably due to GitHub service interruptions. FYI.

@pllim

This comment has been minimized.

Copy link
Member

pllim commented Oct 22, 2018

"unnecessary" -> "unecessary" is a step in the wrong direction?

Except for that one, LGTM. Thanks!

@astrofrog

This comment has been minimized.

Copy link
Member Author

astrofrog commented Oct 22, 2018

@pllim - good catch - it was actually misspelt originally (unneccesary) but the fix was indeed wrong too...

@pllim
pllim approved these changes Oct 22, 2018
@bsipocz

This comment has been minimized.

Copy link
Member

bsipocz commented Oct 22, 2018

unneccesary

that must have been me, one of my regular ones

@pllim

This comment has been minimized.

Copy link
Member

pllim commented Oct 22, 2018

Re: "emittance" -- I would say correcting the spelling is a legit bug fix given the corrected text is now consistent with what is out there?

@bsipocz bsipocz merged commit a7a93e4 into astropy:master Oct 23, 2018
8 of 11 checks passed
8 of 11 checks passed
ci/circleci: 32bit Your tests failed on CircleCI
Details
ci/circleci: html-docs Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
astropy-bot All checks passed
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl202 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl212 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl222 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpl300 Your tests passed on CircleCI!
Details
ci/circleci: image-tests-mpldev Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bsipocz

This comment has been minimized.

Copy link
Member

bsipocz commented Oct 23, 2018

Thanks @astrofrog! I'm not sure the changelog is needed, but since you've already added it can stay :)

bsipocz added a commit that referenced this pull request Oct 30, 2018
Fix spelling mistakes in documentation and code
@astrofrog astrofrog deleted the astrofrog:fix-spelling branch Nov 14, 2018
pllim added a commit to pllim/astropy that referenced this pull request Nov 20, 2018
bsipocz added a commit that referenced this pull request Nov 20, 2018
Move #7942 change log to correct section
bsipocz added a commit that referenced this pull request Nov 23, 2018
Move #7942 change log to correct section
bsipocz added a commit that referenced this pull request Nov 23, 2018
Move #7942 change log to correct section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.