VOTable: Add a warning for integers that are out of range#825
Merged
Conversation
Member
|
Looks good to me if the tests pass. Hopefully the HLA will fix the actual underlying problem, too. |
Contributor
Author
|
I got a report about an hour ago from Rick White that this has been fixed upstream, and I just confirmed here: http://hla.stsci.edu/cgi-bin/hlaSIAP.cgi?inst=ACS&pos=11.888333,-25.288056&size=0.001389 that it has been. |
Member
|
Great, then I'll go ahead and merge this now just in case some other VOTable does this sort of wrongness. |
eteq
added a commit
that referenced
this pull request
Feb 27, 2013
VOTable: Add a warning for integers that are out of range
Contributor
Author
|
Great -- I just tagged this as 0.2.1 (I wasn't able to yesterday). @iguananaut: hopefully that still means it will end up in your merge queue. |
embray
pushed a commit
to embray/astropy
that referenced
this pull request
Mar 29, 2013
VOTable: Add a warning for integers that are out of range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by Andy Ptak in the mailing list thread: "Problem reading VOTable produced by HLA", integers that are out-of-range can cause exceptions from Numpy on certain platforms.
To address this (i.e. not crash) as well as to make it more obvious that the VOTable file is malformed, this PR adds a new warning when an integer value is out of range for the size of the field, and also truncates the value to be within range.