Many Vizier fixes

[jwoillez]

This a re-implementation of Vizier.query_region() to support list of coordinates. The API on the Vizier side seems to have changed. This should fix #1962, fix #1826, fix #1502.

[jwoillez]

WIP: need to fix tests.

[codecov]

Codecov Report

Merging #2012 (570ae48) into master (1a89486) will increase coverage by 0.02%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   67.00%   67.02%   +0.02%     
==========================================
  Files         411      411              
  Lines       27149    27164      +15     
==========================================
+ Hits        18192    18208      +16     
+ Misses       8957     8956       -1     

Impacted Files	Coverage Δ
astroquery/vizier/core.py	74.72% <78.12%> (+1.07%)	⬆️
astroquery/vizier/tests/test_vizier.py	96.75% <100.00%> (+0.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a89486...570ae48. Read the comment docs.

[jwoillez]

I should probably have said so earlier: this PR is ready for review.

[keflavich]

Can we keep the test around and fix it so that it works with the current implementation? I prefer not to remove a test when we still support that functionality

[jwoillez]

@keflavich I will try to make it work. I also need to take care of a bug reported in #1962.

[jwoillez]

@keflavich The test I had removed is back. I had to adjust post_mockreturn to handle the new VizieR list format. I also have a fix for the bug reported in #1962.

[keflavich]

Ready to merge?

[jwoillez]

@keflavich, I have two failing remote tests. With the many changes I have in that PR, I am not too surprised.

[keflavich]

Ah, ok. Are you still working on it, then?

[jwoillez]

I guess so: `Vizier.find_catalog()' is not happy. Let me send a note when all the tests pass.

[jwoillez]

@keflavich Are the remote tests supposed to pass?

[keflavich]

Ideally yes! But if there are upstream changes that break tests, we may just need to note that and move on.

[jwoillez]

When I run the code of test_findcatalog_maxcatalog() by hand, it works. When I run it through astroquery.test(package='vizier', remote_data='any') it fails. Not sure why...

[jwoillez]

It looks like I haven't changed anything related to Vizier.find_catalogs(). I would say these test might have been failing before... If so, I would say good to review or merge from my side.

[keflavich]

OK. Could you open a new issue noting the specific remote failures, so we don't lose track of them? I'll merge this. Thanks.

[bsipocz]

This would need a changelog (rule of thumb: if there is a user facing issue/API bug report, then we need the entry)