Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support building on Windows #11

Merged
merged 2 commits into from
Jan 12, 2016

Conversation

mwcraig
Copy link
Member

@mwcraig mwcraig commented Dec 30, 2015

This fixes (almost) all of the compilation issues. The only one that still comes up is that stdint.h isn't included with the free version of the MS compiler used to build python 2.7. One more reason to switch to python 3.5!

@cmccully
Copy link
Contributor

Thanks for looking at this. Is there a way around the stdint.h problem for windows? If there isn't a good fix, then I will merge this for now and we can look at fixing 2.7 on Windows later.

@mwcraig
Copy link
Member Author

mwcraig commented Jan 12, 2016

My "fix" was to manually copy stdint.h from the MSVC 2015 compiler (which includes it) to the include directory for MSVC 2009 (used to compile python 2.7, doesn't have stdint.h).

I think the only fix is to either provide a link to the file (though I haven't found a link directly to it) or to make a known issue for it in the docs and explain how to work around it.

Path of least pain, by far, for Windows users is to use anaconda and install astroscrappy from the astropy conda channel with:

conda install -c astropy astroscrappy

@cmccully
Copy link
Contributor

Ok. I will merge this. We should probably make a known issue about this in the documentation.

cmccully pushed a commit that referenced this pull request Jan 12, 2016
Changes to support building on Windows
@cmccully cmccully merged commit add5bac into astropy:master Jan 12, 2016
@cmccully
Copy link
Contributor

@mwcraig I tried to merge this, but it failed the Travis CI. Do you mind taking a look. I have never seen this type of failure.

@mwcraig
Copy link
Member Author

mwcraig commented Jan 13, 2016

@cmccully -- weird. Could you try restarting the build to see if it is a one-off problem? Can't see why it would be, but it had built fine on the PR....

@cmccully
Copy link
Contributor

@mwcraig I reran the test and it seemed to work. Very strange. Guess we shouldn't lose sleep over this. Everything should be merged in and ready to go. I will release a minor version shortly.

@mwcraig
Copy link
Member Author

mwcraig commented Jan 13, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants