Cython coverage

[saimn]

Fix #30.

To get the Cython coverage, we need a "develop" build.
Also I moved the linetrace and profile directives, as well as definition of CYTHON_TRACE=1, to be optional since it can have a performance impact for normal builds. So this is activated in the setup.py by setting the COVERAGE env var.

Refs:
https://medium.com/@dfdeshom/better-test-coverage-workflow-for-cython-modules-631615eb197a
http://blog.behnel.de/posts/coverage-analysis-for-cython-modules.html

[codecov]

Codecov Report

Merging #49 into master will decrease coverage by 5.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            master      #49      +/-   ##
===========================================
- Coverage   100.00%   94.88%   -5.12%     
===========================================
  Files            2        7       +5     
  Lines            9     1017    +1008     
  Branches         0       53      +53     
===========================================
+ Hits             9      965     +956     
- Misses           0       52      +52     

Impacted Files	Coverage Δ
astroscrappy/astroscrappy.pyx	75.11% <ø> (ø)
astroscrappy/utils/image_utils.pyx	100.00% <ø> (ø)
astroscrappy/utils/median_utils.pyx	100.00% <ø> (ø)
astroscrappy/utils/medutils.c	100.00% <0.00%> (ø)
astroscrappy/utils/imutils.c	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9f46c...1e6331e. Read the comment docs.

[saimn]

@cmccully - It works! See the coverage report here:
https://codecov.io/gh/astropy/astroscrappy/tree/7ef27224f0ddcf3d63ddf04850222ce39dd42dbe/astroscrappy

[cmccully]

Wow! Awesome!

[cmccully]

Can we add the c files somehow?

[saimn]

In theory yes, with CFLAGS=--coverage, and codecov is running gcov by default, but I was getting a undefined symbol: __gcov_merge_add error. But now I think I know why, let's try it again.

[saimn]

Yes, it works (I was defining CFLAGS in two places, that wasn't good :))
https://codecov.io/gh/astropy/astroscrappy/tree/84c0e9e4ceb0028ab2437dfe34aa441eb06f5326/astroscrappy/utils

[cmccully]

That's awesome!!

[cmccully]

This looks great. Are we ready to merge?

[saimn]

Happy to see this working, it will be useful for other projects :)

[saimn]

Yep, it's good to go!