New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in tpcf_jackknife #513

Closed
aphearin opened this Issue May 24, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@aphearin
Copy link
Contributor

aphearin commented May 24, 2016

Significant bug in tpcf_jackknife function due to incorrect implementation of error_estimation_tools.jackknife_covariance_matrix. The jackknife_covariance_matrix has been entirely deleted from the repo as it was entirely redundant with numpy.cov.

@mclaughlin6464 - my apologies if you have been using this function for science purposes. The jackknife errors you were getting by using tpcf_jackknife were surely incorrect. I have a bug-fix PR that I will submit momentarily.

@aphearin aphearin added this to the v0.2 milestone May 24, 2016

@aphearin aphearin self-assigned this May 24, 2016

aphearin added a commit to aphearin/halotools that referenced this issue May 24, 2016

Bug fixed in tpcf_jackknife, resolving astropy#513.
jackknife_covariance_matrix has been deleted from the repo and replaced with numpy.cov
@mclaughlin6464

This comment has been minimized.

Copy link
Contributor

mclaughlin6464 commented May 25, 2016

No worries, I haven't been using it in detail. However I'll make sure to make sure to pull down these new changes for the future. Thanks for for notifying me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment