New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in units of return value of `delta_sigma` #523

Closed
aphearin opened this Issue May 26, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@aphearin
Copy link
Contributor

aphearin commented May 26, 2016

At a minium, as pointed out by @alexieleauthaud, the units of the return value of the delta_sigma function are not correct. One clear contribution to the problem is that the mean matter density is being set to Nptcl/Vbox, whereas this density must be multiplied by the particle mass to have the correct dimensions. However, resolving this bug should instead implement the mean matter density to be determined by the cosmology of the box. See the empirical_models.phase_space_models.profile_models.profile_helpers.density_threshold function for an example of how this is done.

CC @duncandc - I'm self-assigning this one, but I'll ping you to look at this with me next week.

@aphearin aphearin added this to the v0.2 milestone May 26, 2016

@aphearin aphearin self-assigned this May 26, 2016

@aphearin aphearin closed this in #537 Jun 2, 2016

@aphearin

This comment has been minimized.

Copy link
Contributor Author

aphearin commented Jun 2, 2016

@alexieleauthaud - this bug is now resolved since I have just merged in #537. The delta_sigma function in the master branch is now ready to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment