Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
tpcf jackknife covariance matrix normalization error #815
The covariance matrices in the tpcf_jackknife() mock_observables function aren't correctly normalized.
The tpcf_jackknife() function uses the numpy.cov() function to calculate the covariance matrix which normalizes by default using 1/(N-1) where N is the number of samples. For jackknife samples, it should instead be normalized by (N-1)/N.
Thanks to @yymao for the consultation on this matter.
CC @tmcclintock - you should be aware of this bug. We are fixing asap. I will re-release
I'm pretty sure this is the line, as well as the following two, that need fixing.
According to the numpy docs you need to use either the
Apologies for being too lazy to PR.