New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta sigma from 2d #696

Merged
merged 6 commits into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@aphearin
Copy link
Contributor

aphearin commented Mar 9, 2017

New implementation of delta_sigma function, including API change. Function is more accurate than v0.4 implementation, numerically more stable, faster, and has been generalized to work with simulations that include particles of variable mass, such as hydro or sims with massive neutrinos, resolving #629.

Special thanks to @surhudm for providing an independent implementation of delta sigma, now included in the unit-testing suite to verify code correctness.

CC @duncandc @sssaito

@aphearin aphearin added this to the v0.5 milestone Mar 9, 2017

@aphearin aphearin self-assigned this Mar 9, 2017

@aphearin aphearin merged commit dcbf360 into astropy:master Mar 9, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 87.875%
Details

@aphearin aphearin deleted the aphearin:delta_sigma_from_2d branch Mar 9, 2017

@surhudm

This comment has been minimized.

Copy link
Contributor

surhudm commented Mar 9, 2017

@aphearin

This comment has been minimized.

Copy link
Contributor Author

aphearin commented Mar 9, 2017

You mean, to help beat down sample variance? Or some other motivation?

@surhudm

This comment has been minimized.

Copy link
Contributor

surhudm commented Mar 9, 2017

@aphearin

This comment has been minimized.

Copy link
Contributor Author

aphearin commented Mar 9, 2017

Exactly, it would be effectively impossible to quote error bars this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment