Issue #276 #277
Merged
Issue #276 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peaks_testing` to `FitTrace._bin_peaks`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 87.09% 87.11% +0.02%
==========================================
Files 15 15
Lines 1279 1281 +2
==========================================
+ Hits 1114 1116 +2
Misses 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tepickering
approved these changes
Jul 1, 2025
Contributor
tepickering
left a comment
tepickering
left a comment
There was a problem hiding this comment.
looks good! thanks for the fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #276 by adding a
disp_boundsargument toFitTrace. The argument allows for adjusting the dispersion-axis window from which the trace peaks are estimated. The primary motivation behind this is to make life easier for end-users when tracing a spectrum that would otherwise require cropping.