Refactor dispersion #23

Merged
merged 2 commits into from Apr 8, 2013

Conversation

Projects
None yet
2 participants
@wkerzendorf
Member

wkerzendorf commented Apr 7, 2013

It was agreed upon in the very beginning of this project that the dispersion attribute is called dispersion. This PR fixes this oversight and refactors this code from disp to dispersion.

@keflavich

This comment has been minimized.

Show comment
Hide comment
@keflavich

keflavich Apr 7, 2013

Contributor

I guess you can leave this open if you want to allow for further discussion on disp vs dispersion, but otherwise this PR should probably be merged as soon as you feel comfortable @wkerzendorf.

Contributor

keflavich commented Apr 7, 2013

I guess you can leave this open if you want to allow for further discussion on disp vs dispersion, but otherwise this PR should probably be merged as soon as you feel comfortable @wkerzendorf.

@wkerzendorf

This comment has been minimized.

Show comment
Hide comment
@wkerzendorf

wkerzendorf Apr 7, 2013

Member

@keflavich Okay - I'll leave this open a little bit. am working on other small PRs to fix up the code (documentation and so on).

Member

wkerzendorf commented Apr 7, 2013

@keflavich Okay - I'll leave this open a little bit. am working on other small PRs to fix up the code (documentation and so on).

@wkerzendorf wkerzendorf referenced this pull request Apr 7, 2013

Merged

Fix from table #24

wkerzendorf added a commit that referenced this pull request Apr 8, 2013

@wkerzendorf wkerzendorf merged commit a222801 into astropy:master Apr 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment