Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bad alloc #6

Merged
merged 2 commits into from Nov 9, 2018
Merged

Fix/bad alloc #6

merged 2 commits into from Nov 9, 2018

Conversation

JWhitleyWork
Copy link
Contributor

@JWhitleyWork JWhitleyWork commented Nov 5, 2018 •
edited

Fixes (as far as we can tell) astuff/ibeo_lux#2.

@JWhitleyWork JWhitleyWork mentioned this pull request Nov 5, 2018
Closed
srustanAStuff
srustanAStuff approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@srustanAStuff srustanAStuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, 0xFF is an Ibeo error value. So there only exists 255 (0-254) points.

@JWhitleyWork
Copy link
Contributor Author

Or 0xFFFF for uint16 values.

@rgunjala-as rgunjala-as merged commit 1280bbb into master Nov 9, 2018
@JWhitleyWork JWhitleyWork deleted the fix/bad_alloc branch November 9, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srustanAStuff srustanAStuff srustanAStuff approved these changes

@rgunjala-as rgunjala-as Awaiting requested review from rgunjala-as

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JWhitleyWork @srustanAStuff @rgunjala-as