asutherland / gaia-email-libs-and-more

The indexOf() implementation mechanism for figuring out what index we were
talking about stopped working once we started generating derived
representations instead of putting the canonical database rep in them.

It is likely another round of changes will be required when I update
gaia mail.  It will want to use the newly introduced files in
default_app_logic that probably have issues.

viewFolderConversations still works with the MailDB interaction put in its
own DirectFolderQuery query variant.

Because of jsdoc issue 693 this involves some hand-holding by using
@memberof on the constructors to explicitly place them in the module.
Additionally, @Lends may be needed when mix-ins are used (which makes
sense).

reportError and its aliases ended up shunted to logic.fail anyways, this
patch:
- replaces the still-relevant call-sites to use logic.fail directly
- removes callsites in mailapi that were dead code anyways
- changes the contact cache to use the emitter idiom for 'change'

When triggering conversation display in glodastrophe that doesn't have
snippets already, we end up only fetching the snippet.  This presumably
is something to do with the coalescing logic, but I'd like to use this
as a driving use-case for some logic-inspector improvements.

_sendPromisedRequest-replies now always include an explicit "data" property
which is what the promise gets resolved as.  (The implementation went through
a few spurts, but not all constraints were propagated...)

Account creation was suffering from its assumptions around this API.
learnAboutAccount and tryToCreateAccount should now consistently return values,
with tryToCreateAccount working regardless of whether domainInfo/configInfo is
passed or not.

The account manager will not automatically instantiate the account in order to
trigger syncFolderList.  This assumes a connection is passed-through; a cleanup
in the future would be advisable.

Also:
- Account migration properly occurs and propagates to views.
- Sync folder list offline and online components work happily for vanilla IMAP