Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove key #336

Merged
merged 1 commit into from Apr 15, 2021
Merged

remove key #336

merged 1 commit into from Apr 15, 2021

Conversation

hunterhector
Copy link
Member

This PR removes a private key for security reasons.

@hunterhector hunterhector merged commit cbd7a08 into asyml:master Apr 15, 2021
@hunterhector hunterhector deleted the remove_key branch April 15, 2021 17:08
@huzecong
Copy link
Collaborator

You probably want to rewrite history using bfg and force-push. Otherwise the key stays in commit history forever.

@hunterhector
Copy link
Member Author

hunterhector commented Apr 15, 2021

You probably want to rewrite history using bfg and force-push. Otherwise the key stays in commit history forever.

Good suggestion, I think the key is actually just a public key so there is no real security threat. But we are not using it anymore so we remove it. Do you think it is necessary in danger of making problems on git history?

@huzecong
Copy link
Collaborator

Ah okay then it's probably fine. 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants