Skip to content

Conversation

@async-aws-bot
Copy link
Collaborator

@async-aws-bot async-aws-bot commented Oct 23, 2025

The AWS API contract changed with version 3.357.2.

This PR contains the new definition for Services.

@stof
Copy link
Member

stof commented Oct 23, 2025

The root tests are failing because the refresh script does not properly increment the major version number when we have unreleased BC breaks (and it reverts changes done manually after previous updates). this should be solved to avoid this issue.

However, regarding that particular BC break in the S3 component, I'm wondering whether we should patch the shape for now or release a new major version. The Go SDK applied such patching in aws/aws-sdk-go-v2#3180

@stof
Copy link
Member

stof commented Oct 23, 2025

for the S3 change, the JS SDK patches the shape to keep a Expires timestamp property, adds a new ExpiresString string property and has a translation layer handling the conversion of fields: aws/aws-sdk-js#4577

@jderusse
Copy link
Member

I'm currently AFK for 2 weeks and can't fix the issue in the refresh script.

I think we should not path the manifest to avoid the bc break.
Even if some team in AWS did it, I think we are not AWS and we should not use patch to change signature or add new properties.

@async-aws-bot async-aws-bot force-pushed the bot-code-update branch 2 times, most recently from 8632f02 to 17dfca7 Compare October 25, 2025 06:31
@stof stof merged commit 89ec202 into async-aws:master Oct 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants