Skip to content

Fix the version update for BC breaking changes #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

Fix the version update for BC breaking changes #1965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/bin/refresh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ foreach ($services as $service => $hasChange) {
exit(1);
}
$parts = explode('.', $lastPackageVersion);
$level = 1;
Copy link
Member Author

@stof stof Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this variable is initialized as 1 on line 242. Then, it is updated on line 246 to a value of 0 in case we have changes requiring a major version. But this was lost due to this line.

if (0 === (int) $parts[0]) {
$level = min(2, $level + 1);
}
Expand Down