Add UNKNOWN_TO_SDK value to enums #1998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
unknown-enum
branch
4 times, most recently
from
bb38eb9 to
1d991a6
Compare
fix 1921
jderusse
force-pushed
the
unknown-enum
branch
from
1d991a6 to
5513c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR asserts that enums returned by the API are wellknown values. Otherwise it fallback to the
UNKNOWN_TO_SDKgeneric value.In that way, we respect the contract when saying methods returns a
FooEnum::*.Side note: We still have to keep the psalm exceptions, because psalm can not infer the type of
Enum::exists($value) ? $value : Enum:FALLBACKtoEnum::*.see https://psalm.dev/r/518a0924fe
We would need an equivalent of typescript's
iskeyword https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicatesfix #1921