Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for the createInstance displayName arg. #108

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@artdent
Copy link
Contributor

commented Sep 9, 2019

Description

Add a unit test for the createInstance displayName arg.

Breaking changes

None.

Checklist

Make sure you check all the boxes. You can omit items that are not applicable.

  • Added / updated the unit tests
@now

This comment has been minimized.

Copy link

commented Sep 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@now now bot had a problem deploying to staging Sep 9, 2019 Failure

@codecov

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #108 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #108   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files           8        8           
  Lines         375      375           
  Branches      140      140           
=======================================
  Hits          371      371           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352875a...30e11d2. Read the comment docs.

@ghengeveld

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Thanks! Don't worry about the now deployment, it's been failing since we migrated to async-library and I haven't gotten round to fixing it yet.

@ghengeveld ghengeveld merged commit 1ea71b6 into async-library:next Sep 9, 2019

9 of 10 checks passed

now Deployment has failed
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: chromatic Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: examples Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 352875a...30e11d2
Details
codecov/project 98.93% remains the same compared to 352875a
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.