Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pin API related unsafe code by using pin-project-lite cra… #381

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@taiki-e
Copy link
Member

taiki-e commented Oct 22, 2019

pin-project-lite is a lightweight version of pin-project written with declarative macros.

@taiki-e taiki-e requested a review from stjepang Oct 22, 2019
Copy link
Member

stjepang left a comment

Thank you so much! ♥

This PR removes tons of unsafe code, manual Unpin implementations, and unnecessary Unpin trait bounds. Writing correct stream combinators will be so much easier now.

@stjepang stjepang changed the title Remove Pin API related unsafe code by using pin-project-lite crate Remove Pin API related unsafe code by using pin-project-lite cra… Oct 23, 2019
@stjepang stjepang merged commit 944e43d into async-rs:master Oct 23, 2019
10 checks passed
10 checks passed
Build and test (ubuntu-latest, nightly)
Details
Build and test (windows-latest, nightly)
Details
Build and test (macOS-latest, nightly)
Details
Checking fmt and docs
Details
Clippy check Clippy check
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@taiki-e taiki-e deleted the taiki-e:safe-pin branch Oct 23, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.