Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement an async version of ToSocketAddrs #74
Conversation
|
Thank you for the PR! I think we only need to replace the |
This comment has been minimized.
This comment has been minimized.
|
Force pushed to rebase on master @stjepang Hi, after a long day, I've created a commit to replace |
This comment has been minimized.
This comment has been minimized.
|
Could you perhaps incorporate changes from https://github.com/DCjanus/async-std/pull/1 here? In particular, let's remove the new re-exports and move tests into the |
This comment has been minimized.
This comment has been minimized.
|
@stjepang is this ready to merge? |
|
Some small tweaks are needed and then we'll be ready to merge. |
|
This looks good to me now. Thanks for driving the PR to completion |
This comment has been minimized.
This comment has been minimized.
|
bors r+ |
238a3c8
into
async-rs:master
DCjanus commentedAug 18, 2019
Resolve #50