-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support noOverwriteGlobs
for templates based on react
#1191
Closed
Closed
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
fc81484
Merge pull request #1 from asyncapi/master
lmgyuan 94c04b5
fix noOverwriteGlobs issue #1128
lmgyuan 4bccad3
Merge branch 'fix-noOverwriteGlobs-1128' of https://github.com/lmgyua…
lmgyuan 57ec2ee
give noOverwriteGlobs a default value of []
lmgyuan 8333600
Update integration.test.js
lmgyuan d467476
handle "no such file/directory" error
lmgyuan 4999885
handle output path error
lmgyuan 19e11df
edit package require
lmgyuan c0b9ec8
edit generator parameter
lmgyuan d147b9f
resolved asynchronous issue
lmgyuan 7dd724f
solve asynchronous in test
lmgyuan 1ff0f22
make sure read is executed before checking
lmgyuan 98a1e71
delete unused packages
lmgyuan e9f5bd0
suppress no-duplicate-string
lmgyuan 695e960
Merge branch 'master' into fix-noOverwriteGlobs-1128
derberg 3bb9e6f
add log.debug to replace console.log
lmgyuan 6aa3b59
add debug parameter
lmgyuan 380e210
resolve "unresolved names"
lmgyuan 1b638a2
Merge remote-tracking branch 'upstream/master' into fix-noOverwriteGl…
lmgyuan 30bf2f6
change index.html to use updated test md
lmgyuan a7930b8
update template used for tests
lmgyuan 2e8dda6
use the right way of writing string with variables in javascript
lmgyuan 1047cda
Update comments in test/integration.test.js
lmgyuan a3c0a86
change comments; add log check; store content in variable
lmgyuan 95d44f8
change log variable
lmgyuan 2e6cd81
change output variable
lmgyuan 36815ce
comment out log for test
lmgyuan 655d39b
uncomment log test
lmgyuan e075fff
mock console.log function
lmgyuan a94fd00
comment log
lmgyuan cd22f3e
update Integration.test
lmgyuan 2117147
add existSync
lmgyuan 6ae0b80
update existsSync
lmgyuan 33eb3e5
update logMessages, generator, and integration test
lmgyuan ca40710
update generator and integration.test
lmgyuan 332a4ed
update generator and integration.test
lmgyuan 214387a
update logMessages
lmgyuan e5db0f6
update logMessages and integration
lmgyuan 3505053
update logMessages & integration.test
lmgyuan c4f29c2
delete variables
lmgyuan 038c130
update generator.js and integration test
lmgyuan b2fa883
Merge pull request #3 from asyncapi/master
lmgyuan 15629dc
update to full path
lmgyuan 5e49121
update generator.js, react.js, integration.test.js
lmgyuan a23636a
update generator.js and integration.test
lmgyuan 55f9ae7
update filtersRegistry, generator, integration.test
lmgyuan 900faa9
check whether a file path should be overwritten
lmgyuan 3e7afe7
fixed logging issue
lmgyuan b3b29a1
update generator.js and react.js
lmgyuan 6854f6b
Revert "update generator.js and react.js"
lmgyuan fbd41c8
Update package.json
lmgyuan 09e7882
Revert "fixed logging issue"
lmgyuan 49c8952
Revert "check whether a file path should be overwritten"
lmgyuan eebca77
Revert "update filtersRegistry, generator, integration.test"
lmgyuan 2f3a3ef
Reapply "update filtersRegistry, generator, integration.test"
lmgyuan f5a6251
update package.json & integration.test.js
lmgyuan 0385f26
eliminated unnecessary comments and codes;
lmgyuan be28dea
normalize file path in integration test
lmgyuan 12ada05
normalize testFilePath in integration.test
lmgyuan 06848d4
Update integration.test.js
lmgyuan 1ec96a4
Update integration.test.js
lmgyuan 61d795a
Update integration.test.js
lmgyuan f5180b7
add await to saveContentToFile
lmgyuan 4305a9c
used fspromise
lmgyuan ce41fe0
Merge branch 'master' into fix-noOverwriteGlobs-1128
lmgyuan c741598
Merge branch 'asyncapi:master' into master
lmgyuan 2ee44db
test again
lmgyuan 2d77e3c
delete unnecessary declarations in integration test
lmgyuan 47ae19b
Merge branch 'master' into fix-noOverwriteGlobs-1128
lmgyuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
Empty file.
Empty file.
Empty file.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not
log.debug = jest.fn();
and thenexpect(log.debug)
, then you do not need to domockRestore()
imhoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that. jest.fn() does not work but spyOn() does. The former does not actually track the log.debug() calls in other files, but the latter does by creating a layer of observation around the existing methods.