Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consideration: Protocol specific message objects #42

Closed
gmr opened this issue Oct 26, 2017 · 7 comments · Fixed by #170
Closed

Consideration: Protocol specific message objects #42

gmr opened this issue Oct 26, 2017 · 7 comments · Fixed by #170
Assignees
Labels

Comments

@gmr
Copy link

gmr commented Oct 26, 2017

AMQP, STOMP, MQTT, and others all have variations in the message structure.

I wanted to suggest that you consider the idea of protocol specific message objects or protocol specific message object properties, that embrace the individuality and uniqueness of each protocol's message specification.

In addition, the variations between AMQP 0.9 and 1.0 are enough to warrant protocol version disambiguation.

Have you previously put any thought into this? As someone who's a fairly invested in AMQP 0.9, I'd love to see more detail in that area than what the spec currently provides.

@fmvilas
Copy link
Member

fmvilas commented Oct 27, 2017

That sounds like an excellent idea. Probably, we could accomplish it by extending messages' fields. Example:

lightMeasured:
  summary: Inform about environmental lighting conditions for a particular streetlight.
  payload:
    type: object
    properties:
      lumens:
        type: integer
        minimum: 0
        description: Light intensity measured in lumens.
  amqp:
    version: "0.9.1"
    type: object
    properties:
      somethingUniqueForAMQP: something

There are many (and better) ways to do that but I'm leaving this here as a PoC. Is this what you mean?

@fmvilas
Copy link
Member

fmvilas commented Nov 9, 2017

@gmr ?

@fmvilas fmvilas added the v2.0.0 label Nov 12, 2017
@fmvilas
Copy link
Member

fmvilas commented Nov 12, 2017

This will be addressed in v2 as it's a breaking change.

@gmr
Copy link
Author

gmr commented Nov 14, 2017

Sorry, was heads down @ work. Looks great.

@fmvilas
Copy link
Member

fmvilas commented Nov 14, 2017

Cool. I think a better solution can be thought so feel free to make a proposal if you want. Thanks!

@fmvilas
Copy link
Member

fmvilas commented Feb 8, 2019

This issue sounds like a candidate for many specification extensions (one for each protocol).

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants