-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consideration: Protocol specific message objects #42
Comments
That sounds like an excellent idea. Probably, we could accomplish it by extending messages' fields. Example: lightMeasured:
summary: Inform about environmental lighting conditions for a particular streetlight.
payload:
type: object
properties:
lumens:
type: integer
minimum: 0
description: Light intensity measured in lumens.
amqp:
version: "0.9.1"
type: object
properties:
somethingUniqueForAMQP: something There are many (and better) ways to do that but I'm leaving this here as a PoC. Is this what you mean? |
@gmr ? |
This will be addressed in v2 as it's a breaking change. |
Sorry, was heads down @ work. Looks great. |
Cool. I think a better solution can be thought so feel free to make a proposal if you want. Thanks! |
This issue sounds like a candidate for many specification extensions (one for each protocol). |
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
AMQP, STOMP, MQTT, and others all have variations in the message structure.
I wanted to suggest that you consider the idea of protocol specific message objects or protocol specific message object properties, that embrace the individuality and uniqueness of each protocol's message specification.
In addition, the variations between AMQP 0.9 and 1.0 are enough to warrant protocol version disambiguation.
Have you previously put any thought into this? As someone who's a fairly invested in AMQP 0.9, I'd love to see more detail in that area than what the spec currently provides.
The text was updated successfully, but these errors were encountered: