fix: does not fetch json-schema-07 from web.

[magicmatatjahu]

Description

• does not fetch json-schema-07 from web - serialize the specification to have proper uri for json-schema-draft-07 JSON Schema.

TESTING PR.

Related issue
Fixes #509

[netlify]

✅ Deploy Preview for modest-rosalind-098b67 ready!

Name	Link
🔨 Latest commit	c299fda
🔍 Latest deploy log	https://app.netlify.com/sites/modest-rosalind-098b67/deploys/63a02d44f41529000843b456
😎 Deploy Preview	https://deploy-preview-508--modest-rosalind-098b67.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[fmvilas]

I'm surprised how much you had to do to fix this 🤔 Isn't there a simpler way? We shouldn't be the only ones having this problem.

[magicmatatjahu]

@fmvilas I tried using the http protocol but it didn't work, then I tried removing the schema itself from our definitions and it still didn't work. Only after entering the schema as https (we have to do this manually and change every reference to https) does it work. Both validation and autocompletion. If you have another (worked) idea, you're welcome with contribution 😄

[fmvilas]

So changing the http to https here didn't work?

[magicmatatjahu]

@fmvilas uri ($id field) shouldn't point to the https protocol because json-schema-draft-07 exist as http://json-schema.org/draft-07/schema not https://json-schema.org/draft-07/schema - we shouldn't change $id of default json schema definition. We bundle http://json-schema.org/draft-07/schema just to make it easier for other people, but in the case of the yaml plugin for monaco (in the Studio case) it doesn't work because it only works for https if origin is https and http(s) if origin is http.

[fmvilas]

Oof! 🤦 That's bad. I thought that JSON Schema was serving https://json-schema.org/draft-07/schema with the "$id": "https://json-schema.org/draft-07/schema" value. Would have been great if they could detect when HTTPS or HTTP is used and update accordingly. I know the URL shouldn't strictly be $id (and vice versa) but it would be very handy.

Pinging @Relequestual.

[fmvilas]

Approving as this solution is better than what we have right now.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[magicmatatjahu]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 0.15.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release
• v0.15.2

Your semantic-release bot 📦🚀