refactor: update financial data for current year #2687
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
JeelRajodiya
changed the title
JeelRajodiya
changed the title
JeelRajodiya
changed the title
|
I know using
|
JeelRajodiya
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2687--asyncapi-website.netlify.app/ |
|
@anshgoyalevil can you please review the PR? |
|
@akshatnema @derberg Done! Please review. Here's the summary of the changes
|
|
cc : @akshatnema @derberg |
|
@akshatnema Done! Please Review |
|
@akshatnema reminder for this PR |
|
@akshatnema gentle reminder |
|
@JeelRajodiya please resolve the merge conflicts |
|
/update |
|
@JeelRajodiya please resolve the conflicts |
|
Yes I will update it, Need some time |
JeelRajodiya
force-pushed
the
auto-year-detection
branch
from
474cdeb
to
e31f020
Compare
|
PR is ready for review |
| import(`../../config/finance/json-data/${currentYear}/ExpensesLink.json`).then((data) => | ||
| setExpensesLinkData(data.default) | ||
| ); | ||
| getUniqueCategories().then((data) => setCategories(data)); | ||
| import(`../../config/finance/json-data/${currentYear}/Expenses.json`).then((data) => setExpensesData(data.default)); |
There was a problem hiding this comment.
What if Expenses Files of current are not present? In that case this import will lead to error and a deadlock situation will be created. Provide some fallback for these imports.
There was a problem hiding this comment.
I have added some logic for checking whether we have any financial data or not, please view scripts/index.js. If we do not have any financial data, it will throw an error on the build. Also, I have moved those imports on the top level now.
|
We are now using a different approach. When the project is built, the @akshatnema PTAL |
Description
When the year changes, we create a folder for that particular year, and along with that, we need to change the year in some files (scripts/finance/index.js , lib/getUniqueCategories.js and components/FinancialSummary/BarChartComponent.js) to update the bar chart. However, what we can do is write logic to automatically detect the current year and modify the year in those files when we create a folder for the year in the finance section.
Closes #2686