Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: tools/generator button alignment #2848

Closed
wants to merge 4 commits into from
Closed

style: tools/generator button alignment #2848

wants to merge 4 commits into from

Conversation

RamGoel
Copy link
Contributor

@RamGoel RamGoel commented Apr 7, 2024

Description
This PR fixes the button alignment on tools/generator page.

Related issue(s)
Fixes #2847

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e8b8c2
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66304a394a544200089f9d97
😎 Deploy Preview https://deploy-preview-2848--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Apr 7, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2848--asyncapi-website.netlify.app/

@anshgoyalevil
Copy link
Member

This doesn't look as expected :)

image

@sambhavgupta0705
Copy link
Member

@RamGoel the buttons are not aligned
image

@RamGoel
Copy link
Contributor Author

RamGoel commented Apr 30, 2024

Hey @sambhavgupta0705 @anshgoyalevil sorry guys for delaying it too much. I've pushed the fix and it's looking as expected now

@RamGoel RamGoel closed this by deleting the head repository May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Overlapping buttons on tools/generator page
4 participants