-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reduce the number of renders in Dashboad page #3039
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3039--asyncapi-website.netlify.app/ |
@@ -32,6 +32,8 @@ export function filterIssues(issues: Issue[], filters: FiltersType): Issue[] { | |||
result = result.filter((issue) => issue.area === filters.selectedArea); | |||
} | |||
|
|||
console.log(result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this console log statement.
@akshatnema I have done the changes.Please review it. |
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary spaces.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok removed the unnesscary spaces as you requested. |
@akshatnema Do I need to make changes in this PR or is it OK ? |
/update |
/update |
Description
useMemo in Dashboard component to reduce unnecessary renders of repo when page loads.
Also removed scroll errors in Good Frist Issues section.
In the website :
![Screenshot 2024-06-12 215352](https://private-user-images.githubusercontent.com/115544445/339053128-2084bd21-5262-4fb9-8f65-2bea47294bd7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwNjg5MzcsIm5iZiI6MTcyNTA2ODYzNywicGF0aCI6Ii8xMTU1NDQ0NDUvMzM5MDUzMTI4LTIwODRiZDIxLTUyNjItNGZiOS04ZjY1LTJiZWE0NzI5NGJkNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODMxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgzMVQwMTQzNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MmQwNTdkMmMwOGM3ZjE2OTQyNmVhOTIwNTkzYjg0NzVjMjhiNmI4MjlmNTBiYjZjNjkyOGJiNzE5ZjBkMjIxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.quk506VQltom_N7sCH6_KhE7yFK57xnbuaBcw-bpTAA)
Change:
![image](https://private-user-images.githubusercontent.com/115544445/339053949-b3374c2e-a495-4b38-8bc9-7e7025b8cf90.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwNjg5MzcsIm5iZiI6MTcyNTA2ODYzNywicGF0aCI6Ii8xMTU1NDQ0NDUvMzM5MDUzOTQ5LWIzMzc0YzJlLWE0OTUtNGIzOC04YmM5LTdlNzAyNWI4Y2Y5MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODMxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgzMVQwMTQzNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xZjAyOTY2NzBiMDhjYTg5MDI4MDU4ZjdjMGEwY2E1YTYxYmE2MDhjNTBlM2ViNTlmZDE1YjU4Njk5YTEzMTQ3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.LlOWqtrALdwAQ_xzdmgtSBXd9qWdu1W3B2gMVAbD3C0)