Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce the number of renders in Dashboad page #3039

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Manush-2005
Copy link

Description

  • useMemo in Dashboard component to reduce unnecessary renders of repo when page loads.

  • Also removed scroll errors in Good Frist Issues section.

In the website :
Screenshot 2024-06-12 215352

Change:
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e7c030a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/669fe6a2aa279100088e8645
😎 Deploy Preview https://deploy-preview-3039--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Jun 12, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 34
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3039--asyncapi-website.netlify.app/

@@ -32,6 +32,8 @@ export function filterIssues(issues: Issue[], filters: FiltersType): Issue[] {
result = result.filter((issue) => issue.area === filters.selectedArea);
}

console.log(result);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this console log statement.

components/dashboard/GoodFirstIssues.tsx Outdated Show resolved Hide resolved
@Manush-2005
Copy link
Author

@akshatnema I have done the changes.Please review it.

@Manush-2005 Manush-2005 reopened this Jun 15, 2024
@akshatnema akshatnema changed the title refactor: useMemo in Dashboard to reduce unnecessary renders and remove scroll arrows in Good Frist Issues section in Dashboard. refactor: reduce the number of renders in Dashboad page Jun 15, 2024
Comment on lines 64 to 65


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Remove unnecessary spaces.

Comment on lines 35 to 36


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@Manush-2005
Copy link
Author

Ok removed the unnesscary spaces as you requested.

@Manush-2005
Copy link
Author

@akshatnema Do I need to make changes in this PR or is it OK ?

@sambhavgupta0705
Copy link
Member

/update

@sambhavgupta0705
Copy link
Member

@anshgoyalevil @akshatnema PTAL

@sambhavgupta0705
Copy link
Member

/update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants