Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: asyncly/EventEmitter2
base: master
...
head fork: FugueNation/EventEmitter2
compare: master
Checking mergeability… Don't worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 2 commit comments
  • 1 contributor
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/eventemitter2.js
View
4 lib/eventemitter2.js
@@ -110,7 +110,7 @@
if (m > 0 && tree._listeners.length > m) {
tree._listeners.warned = true;
- console.error('(node) warning: possible EventEmitter memory ' +
+ console.warn('(node) warning: possible EventEmitter memory ' +
'leak detected. %d listeners added. ' +
'Use emitter.setMaxListeners() to increase limit.',
tree._listeners.length);
@@ -289,7 +289,7 @@
if (m && m > 0 && this._events[type].length > m) {
this._events[type].warned = true;
- console.error('(node) warning: possible EventEmitter memory ' +
+ console.warn('(node) warning: possible EventEmitter memory ' +
'leak detected. %d listeners added. ' +
'Use emitter.setMaxListeners() to increase limit.',
this._events[type].length);

Showing you all comments on commits in this comparison.

@hij1nx
Owner

Node.js-core throws errors. If you have a compelling reason for this i'll definitely reconsider.

@FugueNation

The message text clearly says 'warning', which leads me to believe I'd want its output on console.warn, especially in the case I'm logging console output by levels. Seems very rational and obvious to me. However if core is putting warnings on the console.error channel, even if it seems weird, I guess sticking with precedent is better. So you can just close this one. No problem!

Something went wrong with that request. Please try again.