Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split FindByColumnHeaderStrategy.Find method #249

Closed
YevgeniyShunevych opened this issue Apr 18, 2019 · 0 comments

Comments

1 participant
@YevgeniyShunevych
Copy link
Member

commented Apr 18, 2019

Extract 2 methods from FindByColumnHeaderStrategy.Find method to give ability to override them:

protected virtual int? GetColumnIndex(IWebElement scope, ComponentScopeLocateOptions options, SearchOptions searchOptions);

protected virtual IComponentScopeLocateStrategy CreateColumnIndexStrategy(int columnIndex);

@YevgeniyShunevych YevgeniyShunevych added this to the 1.1.0 milestone Apr 18, 2019

@YevgeniyShunevych YevgeniyShunevych self-assigned this Apr 18, 2019

YevgeniyShunevych added a commit that referenced this issue Apr 18, 2019

#248 Add HeaderXPath property to FindByColumnHeaderStrategy; #249 Spl…
…it FindByColumnHeaderStrategy.Find method; Add XML comments to FindByColumnHeaderStrategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.